Review Request 127218: properties for configurationRequired/configurationRequiredReason

[Marco Martin]

> On Feb. 29, 2016, 12:19 p.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, lines 75-76
> > <https://git.reviewboard.kde.org/r/127218/diff/1/?file=445992#file445992line75>
> >
> >     why copy the string?
> 
> Kai Uwe Broulik wrote:
>     We need a getter for this.

yeah, i tried to do without adding a getter in Applet, adding it now, it should make things easier


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127218/#review92895
-----------------------------------------------------------


On Feb. 29, 2016, 12:15 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127218/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 12:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> unbreak api of Applet::SetConfigurationRequired + add bindings to appletInterface as properties.
> 
> 
> It would still need somewhere the creation of graphics for that, probably in the containments code.
> 
> 
> Diffs
> -----
> 
>   src/plasma/applet.h df57e94 
>   src/plasma/applet.cpp 4ce2d28 
>   src/plasma/private/applet_p.h e1aaef6 
>   src/plasma/private/applet_p.cpp 949c92e 
>   src/scriptengines/qml/plasmoid/appletinterface.h 8dcac08 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d 
> 
> Diff: https://git.reviewboard.kde.org/r/127218/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/d2b5e012/attachment.html>