Review Request 127217: Move contextualActionsAboutToShow to Applet

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127217/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 12:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 88ec6de11392710df72f2bab6139dc385596743a by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

Applet contains the menu actions, therefore notifying the menu needs updating should
happen in Applet not AppletInterface. With AppletInterface being a dumb
wrapper.

This exposes functionality to anyone who overrides Applet, but also will
also allows system tray to emit this signal without having to use
private API.

This is a better version of my patch at https://git.reviewboard.kde.org/r/126811/ to fix 358119 that I wasn't happy with.


Diffs
-----

  src/plasma/applet.h df57e945b7dcd3b907c68ae82e5a26f2caeb5c9f 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d05640cc02a1a2bda546601e6740a9b4e9 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 44ed56ed85adec4af054a25c1cc5b46605152320 

Diff: https://git.reviewboard.kde.org/r/127217/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/44e349ee/attachment.html>