Review Request 127197: [kcm_colors] Port away from KDELibs4Support

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127197/#review92875
-----------------------------------------------------------


Ship it!




Please put the change into master not into the Plasma/5.5. bracnh.

Concerning the leak: I noticed in the past that KTextEditor based applications run amok once you change the color scheme. No idea whether it's related, but it could be.

- Martin Gräßlin


On Feb. 27, 2016, 9:27 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127197/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 9:27 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, David Edmundson, David Faure, Hugo Parente Lima, and Thomas Lübking.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Start porting to find leaks on X in radeon driver.
> 
> 
> Diffs
> -----
> 
>   kcms/colors/CMakeLists.txt f02e0eb 
>   kcms/colors/colorscm.h 8e74e8a 
>   kcms/colors/colorscm.cpp f3c4f05 
> 
> Diff: https://git.reviewboard.kde.org/r/127197/diff/
> 
> 
> Testing
> -------
> 
> 1. Open dolphin, kate, etc...
> 2. kcmschell5 colors
> 3. Apply color scheme
> 4. Extremly leak on X
> The bug is in this peace of code
> QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KGlobalSettings"), QStringLiteral("org.kde.KGlobalSettings"), QStringLiteral("notifyChange") );
>     QList<QVariant> args;
>     args.append(0);//previous KGlobalSettings::PaletteChanged. This is now private API in khintsettings
>     args.append(0);//unused in palette changed but needed for the DBus signature
>     message.setArguments(args);
>     QDBusConnection::sessionBus().send(message);
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160227_102609.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/27/a23bfdad-7465-422e-9cef-25fe7991e795__Screenshot_20160227_102609.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160229/bb42d042/attachment.html>