Review Request 127214: Remove some warnings

Aleix Pol Gonzalez aleixpol at
Sun Feb 28 23:36:31 UTC 2016

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Frameworks and Plasma.

Repository: plasma-framework


* Unused variables
* Unused code
* Unused arguments
* Unnecessarily complex code
* Initialization order
* Duplicated properties

It would be _very_ good if we could get rid of Plasma::Package usage within Plasma Framework. I'm quite confident most of these warnings would have been fixed already if it wasn't because we're flooded with deprecated API usage warnings.


  autotests/pluginloadertest.cpp b75dd03 
  src/declarativeimports/calendar/daysmodel.cpp 1faf43b 
  src/declarativeimports/calendar/eventpluginsmanager.cpp 343d586 
  src/declarativeimports/core/quicktheme.h b8017d2 
  src/declarativeimports/platformcomponents/application.cpp bdcc9b4 
  src/plasma/private/applet_p.cpp 1c0515a 
  src/plasma/private/theme_p.cpp b18e1fa 
  src/plasma/service.cpp a512569 
  src/plasmapkg/plasmapkg.cpp 138b2fe 



Builds, tests pass.


Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list