Review Request 127201: Fix svg icon path resolving in IconItem

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127201/#review92838
-----------------------------------------------------------



can we extend the unit test to cover this?

- Kai Uwe Broulik


On Feb. 27, 2016, 6:53 nachm., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127201/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 6:53 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Well.. the bug should be obvious:
> 1. QString iconPath overrides the iconPath in a higher scope. introduced in https://git.reviewboard.kde.org/r/126168/
> 2. iconPath not assigned, also introduced in https://git.reviewboard.kde.org/r/126168/
> 3. svgz -> svg?? introduced in https://git.reviewboard.kde.org/r/126557/
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.cpp 085f284 
> 
> Diff: https://git.reviewboard.kde.org/r/127201/diff/
> 
> 
> Testing
> -------
> 
> tested with qmlscene with Plasma.IconItem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160227/66f8fb7d/attachment.html>