Review Request 127173: Avoid unset values in comicdata

[David Edmundson]

> On Feb. 25, 2016, 9:54 a.m., Marco Martin wrote:
> > Ship It!
> 
> Marco Martin wrote:
>     perhaps related to https://bugs.kde.org/show_bug.cgi?id=359614 ?

that's the reason I had a comic strip on my desktop :)
but I don't see from the traces (sorry, I didn't save my valgrind trace) how they could be the same.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127173/#review92758
-----------------------------------------------------------


On Feb. 25, 2016, 1:03 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127173/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 1:03 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> The default constructor is sometimes called.
> At which point we end up using uninitiased values.
> 
> 
> Diffs
> -----
> 
>   applets/comic/comicdata.h 85ccbd5dbfd14a74025ebc38cd9729f6e9c16514 
>   applets/comic/comicdata.cpp 85be78105d435863d0df8d3b2b9c246b7e6232d5 
> 
> Diff: https://git.reviewboard.kde.org/r/127173/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160225/b13b7f27/attachment.html>