Review Request 127174: Only build the decoration if the KDecoration2 is present

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127174/#review92752
-----------------------------------------------------------



Same comment as always in such cases: if we do that we end up with Plasma installs without Breeze deco, because distros don't check the optional output.

I understand your reasoning, but I think it needs a dedicated switch and a big fat warning

- Martin Gräßlin


On Feb. 25, 2016, 2:20 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127174/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 2:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> I want to have Breeze in the XDG-App runtime, it seemed like having kdecoration wouldn't be very useful there.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 93ad504 
> 
> Diff: https://git.reviewboard.kde.org/r/127174/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160225/5530f5c8/attachment.html>