Review Request 126740: Add a script for optimizing svgs

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 24 17:23:13 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 5:23 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 8a31ac8ac1056a9065d50845b71336fff74e317c by Aleix Pol to branch master.


Repository: breeze-icons


Description
-------

Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea that right now we're serving right away the svg's from inkscape and there's room for improvement, potentially.

This patch just introduces a script that optimizes the svg's using `svgo`.

More could be done, like using gzip files, we can look into that if anyone's interested. In fact, we used to use svgz for the icons, I wonder why that changed. 

This will change the files in-place rather than as a build step, which is what I considered first. The process to run svgo on every file was about 30 minutes to 1h on my system, so I doubt it's really desirable.

A reduced file size is important because it will greatly reduce disk IO, which is a bottle-neck we have.


Diffs
-----

  optimize.svg.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126740/diff/


Testing
-------

```
kde-devel at oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
32M     icons
32M     icons-dark/

#run the script

kde-devel at oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
17M     icons
17M     icons-dark/
```


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160224/df5dc615/attachment.html>


More information about the Plasma-devel mailing list