Review Request 127168: select theme from command line in testing mode

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127168/#review92729
-----------------------------------------------------------




greeter/greeterapp.cpp (line 141)
<https://git.reviewboard.kde.org/r/127168/#comment63186>

    this looks to me like any config value stored in kdeglobals will overwrite what was set in setTheme again.
    
    My suggestion would be to maybe only read the value if it is not yet set:
        if (m_packageName.isEmpty()) {
            m_packageName = cg.readEntry("...")
        }


- Martin Gräßlin


On Feb. 24, 2016, 4:30 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127168/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 4:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> -------
> 
> this enables a --theme option in order to test different lockers.
> for precaution only when ---testing is passed as well
> 
> 
> Diffs
> -----
> 
>   greeter/greeterapp.h 380bea8 
>   greeter/greeterapp.cpp 7e21742 
>   greeter/main.cpp 0460602 
> 
> Diff: https://git.reviewboard.kde.org/r/127168/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160224/787d76e5/attachment.html>