Review Request 126793: KF5 (Picture) Frame plasmoid

[Lars Pontoppidan]

> On Feb. 24, 2016, 10:34 a.m., Lars Pontoppidan wrote:
> > Ship It!
> 
> Marco Martin wrote:
>     you can do the actual merge now, you still have to do it via git.
> 
> Lars Pontoppidan wrote:
>     I've done my best - it's in master now :) - Thanks
> 
> Marco Martin wrote:
>     i closed the review as submitted then (hint: if the commit has REVIEW:126793 in the comments, it will automatically close it)

Ok - I actually did that - but with a space between "REVIEW:" and "126793" - https://quickgit.kde.org/?p=kdeplasma-addons.git&a=commit&h=026aa6da83790a217284ee68675534500cd54e3c 
... anyway I'll remember it till next time :)

Thanks!


- Lars


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/#review92714
-----------------------------------------------------------


On Feb. 24, 2016, 12:03 p.m., Lars Pontoppidan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126793/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 12:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> KF5 version of the (Picture) Frame widget
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt ed938f8 
>   applets/mediaframe/CMakeLists.txt PRE-CREATION 
>   applets/mediaframe/Messages.sh PRE-CREATION 
>   applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
>   applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
>   applets/mediaframe/package/metadata.desktop PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
>   applets/mediaframe/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126793/diff/
> 
> 
> Testing
> -------
> 
> kdeplasma-addons builds on Kubuntu 15.10.
> 
> 
> Thanks,
> 
> Lars Pontoppidan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160224/6f938b32/attachment.html>