[Differential] [Updated] D1009: Added indicator of whether there are windows in an activity to the switcher

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Tue Feb 23 06:42:34 UTC 2016


graesslin added a comment.


  I think all your ifdefs are not needeed. Neither are the x11 runtime checks.

INLINE COMMENTS
  imports/activitymanager/sortedactivitiesmodel.cpp:195-217 I don't understand why you made this conditional. It should also work on Wayland.
  imports/activitymanager/sortedactivitiesmodel.h:25 Note: the code in kwindowsystem goes back to KDE 3 time and is clearly not written by me.
  imports/activitymanager/sortedactivitiesmodel.h:36-43 NET Properties are not X11 specific. They are available on all platforms.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1009

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, sebas, davidedmundson, mart, graesslin
Cc: broulik, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160223/04684081/attachment.html>


More information about the Plasma-devel mailing list