Review Request 127124: Fixed minimum width for the notes applet so that buttons never leak

[Viorel-Cătălin Răpițeanu]

> On Feb. 20, 2016, 6:10 p.m., Aleix Pol Gonzalez wrote:
> > applets/notes/package/contents/ui/main.qml, line 48
> > <https://git.reviewboard.kde.org/r/127124/diff/1/?file=444742#file444742line48>
> >
> >     That's a hack, you shouldn't rely on such made up values.
> >     
> >     try:
> >     Plasmoid.switchWidth: Math.max(units.gridUnit * 13, fontButtons.Layout.preferredWidth)

I know I shouldn't rely on magic numbers, but I couldn't think of a better solution for it.
I like your solution because it gives a bit more flexibility. It works as expected.


- Viorel-Cătălin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127124/#review92582
-----------------------------------------------------------


On Feb. 20, 2016, 11:37 p.m., Viorel-Cătălin Răpițeanu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127124/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 11:37 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Sebastian Kügler.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> When resizing the notes applet to the minimum size, the 'Notes Settings' button was leaking when hovered.
> 
> ![Image description](http://s2.postimg.org/pb2ruhz49/notes_applet_width.png)
> 
> 
> Diffs
> -----
> 
>   applets/notes/package/contents/ui/main.qml e3f2099 
> 
> Diff: https://git.reviewboard.kde.org/r/127124/diff/
> 
> 
> Testing
> -------
> 
> The testing was done locally by installing the modified version. The minimum size doesn't allow the buttons to leak anymore.
> 
> 
> Thanks,
> 
> Viorel-Cătălin Răpițeanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160220/af770f85/attachment.html>