Review Request 127118: ToolTip: Don't change geometry twice when repositioning

David Rosca nowrep at gmail.com
Fri Feb 19 21:04:41 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127118/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

Dialog::setLocation and Dialog::setVisualParent both calls syncWithItem which changes the dialog's geometry.
Unsetting the mainItem and setting it back after location and visual parent is updated defers the call to syncWithItem and updates the geometry only once.


Diffs
-----

  src/declarativeimports/core/tooltip.cpp 3d2e7da 

Diff: https://git.reviewboard.kde.org/r/127118/diff/


Testing
-------

Tested with morphing popups effect, only one geometry change event is sent when tooltip slides to new position.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160219/dbee99c5/attachment.html>


More information about the Plasma-devel mailing list