Review Request 127115: SvgItem: Don't use Plasma::Theme from rendering thread

David Rosca nowrep at gmail.com
Fri Feb 19 17:22:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127115/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 5:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 596fa082ddd065d216de794a9d9177d79e03b7a3 by David Rosca to branch master.


Repository: plasma-framework


Description
-------

Logic is similar to IconItem - rendered image is updated in updatePolish().


Diffs
-----

  src/declarativeimports/core/svgitem.h 7f9e44c 
  src/declarativeimports/core/svgitem.cpp 849c85f 

Diff: https://git.reviewboard.kde.org/r/127115/diff/


Testing
-------

scheduleImageUpdate() is called wherever m_textureChanged is set to true + when geometry changes, so it should be identical to old code.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160219/eedfd5bd/attachment.html>


More information about the Plasma-devel mailing list