Review Request 127115: SvgItem: Don't use Plasma::Theme from rendering thread

David Rosca nowrep at gmail.com
Fri Feb 19 15:01:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127115/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

Logic is similar to IconItem - rendered image is updated in updatePolish().


Diffs
-----

  src/declarativeimports/core/svgitem.h 7f9e44c 
  src/declarativeimports/core/svgitem.cpp 849c85f 

Diff: https://git.reviewboard.kde.org/r/127115/diff/


Testing
-------

scheduleImageUpdate() is called wherever m_textureChanged is set to true + when geometry changes, so it should be identical to old code.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160219/8ace80f6/attachment-0001.html>


More information about the Plasma-devel mailing list