Review Request 127073: AppletQuickItem: Fix finding own attached layout

[David Rosca]

> On Feb. 19, 2016, 12:02 p.m., David Edmundson wrote:
> > src/plasmaquick/appletquickitem.cpp, lines 572-573
> > <https://git.reviewboard.kde.org/r/127073/diff/2/?file=444222#file444222line572>
> >
> >     can you get rid of this. 
> >     
> >     I think it's trying to do what your patch does, only it doesn't work. (p.isValid() is always false)

Yes, I guess it tries to create the Layout, but it doesn't really work. I think it was valid for some items when I tested it, but it still didn't have any effect.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92552
-----------------------------------------------------------


On Feb. 13, 2016, 11:48 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
>     http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> -------
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160219/62b6f336/attachment.html>