Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

[Marco Martin]

> On Dec. 28, 2015, 9:50 a.m., David Rosca wrote:
> > What about just adding a property to disable animation (as Eike suggested) and disable it for icon in tooltips?
> > 
> > Currently, only the icon is animated when the tooltip contents change, text (tooltip title, subtitle) is changed immediately. I think it would look better if either both were animated, or neither.
> > 
> > Also right now, the tooltips from systray (all tooltips without custom contents) don't have the crossfade animation at all, so I can no longer reproduce this bug.
> 
> Marco Martin wrote:
>     I would be open to a patch for such a property
> 
> David Rosca wrote:
>     This property is already in IconItem, or did you mean disabling animation for icons in tooltips?

yes, animation of icons in tooltips should be disabled now that is animated with other means


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review90201
-----------------------------------------------------------


On Dec. 28, 2015, 12:17 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 12:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We have a lot of reusable singletons that are just hidden when unneeded (tooltip, osd). IconItem, however, will always fade from the previous state, even if the previous action happened minutes ago.
> 
> This patch makes it track its visibility and skip the fade-and-wait dance when it just became visible. It also removes a visible false call in the tooltip which I didn't know what it was for. (With it in place, the IconItem always becomes visible when moving between tooltip areas, breaking the animation altogether).
> 
> @Eike: Could you check whether this makes it more viable for Kicker?
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 528f57c 
>   src/declarativeimports/core/iconitem.cpp 1e8260e 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
> 
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
> 
> 
> Testing
> -------
> 
> Moving between tray icons - icon fades, moving reaaaally rapidly causes it not to load any icon until you halt (dunno if that happened before but doesn't seem too bad)
> Hovering tray icon, leaving, waiting, hovering another one - icon does not fade, is there right away
> Notifications also don't fade from the previously issued notification icon
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160217/bb9b0621/attachment.html>