Review Request 127085: Make the desfault theme follow system colors

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127085/#review92462
-----------------------------------------------------------



Nice!


File Attachment: color1.png - color1.png
<https://git.reviewboard.kde.org//r/127085/#fcomment501>

    While I see the point in the bezel using text color, here it looks really weird, and the other icons do not.



File Attachment: color3.png - color3.png
<https://git.reviewboard.kde.org//r/127085/#fcomment502>

    This is not exactly the same color - probably needs fixing/deciding on which to use.



File Attachment: color4.png - color4.png
<https://git.reviewboard.kde.org//r/127085/#fcomment503>

    What's going on there?



File Attachment: color4.png - color4.png
<https://git.reviewboard.kde.org//r/127085/#fcomment504>

    This is hard to read, perhaps the background contrast effect is still using light color?


- Kai Uwe Broulik


On Feb. 16, 2016, 12:28 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127085/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 12:28 nachm.)
> 
> 
> Review request for Plasma and Jens Reuterberg.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this makes the default plasma theme follow system colors, there are still "breeze light" and "breeze dark" themes that behave like the old two
> 
> 
> Diffs
> -----
> 
>   src/desktoptheme/CMakeLists.txt 3087c17 
>   src/desktoptheme/breeze-light/CMakeLists.txt PRE-CREATION 
>   src/desktoptheme/breeze-light/colors PRE-CREATION 
>   src/desktoptheme/breeze-light/metadata.desktop PRE-CREATION 
>   src/desktoptheme/breeze/CMakeLists.txt 2e28287 
>   src/desktoptheme/breeze/colors d701701 
> 
> Diff: https://git.reviewboard.kde.org/r/127085/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> color1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/24f7dc82-1d66-4052-bc6f-af4aab0f15df__color1.png
> color2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/93188d4f-242a-46ac-94a7-182ed600817b__color2.png
> color3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/5151b63c-476b-4ff3-a653-42bf8168836f__color3.png
> color4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/41febde6-795d-437c-b17e-ace92c84ea73__color4.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160216/b5952517/attachment-0001.html>