Review Request 127085: Make the desfault theme follow system colors

Andreas Kainz kainz.a at gmail.com
Tue Feb 16 12:27:16 UTC 2016



> On Feb. 16, 2016, 12:09 nachm., David Edmundson wrote:
> > Breeze theme version needs bumping as you need the cache to clear.
> > 
> > Are you planning on migrating existing users onto breeze-light?
> 
> Marco Martin wrote:
>     hmm no, I wanted to have existing users to the new one, if they don't have weird color schemes they don't notice, otherwise they'll find the whole desktop on the same color scheme, that i think makes sense (they can still go back to breeze light)
>     
>     If the vdg thinks that it's not an unacceptable default change, we can do a kconfupdate script
> 
> Andreas Kainz wrote:
>     how does the monochrome system tray icons look like cause they use also the colors from system color?
> 
> Marco Martin wrote:
>     yes, like the k menu
> 
> Andreas Kainz wrote:
>     Is it possible to 1. change the behavior and 2. do the kde applications (e.g. dolphin) use also colored monochrome icons?
> 
> Marco Martin wrote:
>     neither of those, sorry

It look like a biger change so how can I test your review?


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127085/#review92431
-----------------------------------------------------------


On Feb. 16, 2016, 10:29 vorm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127085/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 10:29 vorm.)
> 
> 
> Review request for Plasma and Jens Reuterberg.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this makes the default plasma theme follow system colors, there are still "breeze light" and "breeze dark" themes that behave like the old two
> 
> 
> Diffs
> -----
> 
>   src/desktoptheme/CMakeLists.txt 3087c17 
>   src/desktoptheme/breeze-light/CMakeLists.txt PRE-CREATION 
>   src/desktoptheme/breeze-light/colors PRE-CREATION 
>   src/desktoptheme/breeze-light/metadata.desktop PRE-CREATION 
>   src/desktoptheme/breeze/CMakeLists.txt 2e28287 
>   src/desktoptheme/breeze/colors d701701 
> 
> Diff: https://git.reviewboard.kde.org/r/127085/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> color1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/24f7dc82-1d66-4052-bc6f-af4aab0f15df__color1.png
> color2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/93188d4f-242a-46ac-94a7-182ed600817b__color2.png
> color3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/5151b63c-476b-4ff3-a653-42bf8168836f__color3.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160216/63310483/attachment-0001.html>


More information about the Plasma-devel mailing list