Review Request 126740: Add a script for optimizing svgs

Aleix Pol Gonzalez aleixpol at
Tue Feb 16 02:02:42 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 16, 2016, 3:02 a.m.)

Review request for KDE Frameworks and Plasma.


Fixes the issues pointed out by Alexander Richardson, who seems to have a bash-fu over 9000.

Furthermore, it also includes a check to make sure that the generated file isn't too different to the new one (by rendering them with inkscape and comparing), if that's the case it leaves the tmp file and continues with the rest.

Repository: breeze-icons


Dirk's review ( gave me the idea that right now we're serving right away the svg's from inkscape and there's room for improvement, potentially.

This patch just introduces a script that optimizes the svg's using `svgo`.

More could be done, like using gzip files, we can look into that if anyone's interested. In fact, we used to use svgz for the icons, I wonder why that changed. 

This will change the files in-place rather than as a build step, which is what I considered first. The process to run svgo on every file was about 30 minutes to 1h on my system, so I doubt it's really desirable.

A reduced file size is important because it will greatly reduce disk IO, which is a bottle-neck we have.

Diffs (updated)



kde-devel at oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
32M     icons
32M     icons-dark/

#run the script

kde-devel at oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
17M     icons
17M     icons-dark/


Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list