Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127083/#review92416
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Feb. 15, 2016, 9:07 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127083/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2016, 9:07 p.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Bugs: 357699
>     http://bugs.kde.org/show_bug.cgi?id=357699
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Instead of showing an empty popup when clicking on the DiskQuota applet, this patch changes shows a label saying "No quota restrictions found." This is in line with with the tool tip, so even no new i18n string is added.
> 
> This also fixes part of bug #357699 (the icon is still missing, for whatever reason, I can reproduce that on openSUSE Leap 42.1).
> 
> 
> Diffs
> -----
> 
>   applets/diskquota/package/contents/ui/main.qml c749c8b 
> 
> Diff: https://git.reviewboard.kde.org/r/127083/diff/
> 
> 
> Testing
> -------
> 
> Compiles and works as expected, tested with plasma development version.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160215/289216b6/attachment.html>