Review Request 127075: Prefer other containments than desktop in containmentAt()

David Rosca nowrep at gmail.com
Mon Feb 15 18:11:05 UTC 2016



> On Feb. 15, 2016, 5:58 p.m., Kai Uwe Broulik wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 273
> > <https://git.reviewboard.kde.org/r/127075/diff/1/?file=444321#file444321line273>
> >
> >     Q_NULLPTR in Frameworks

Fixed in push


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127075/#review92412
-----------------------------------------------------------


On Feb. 15, 2016, 6:10 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127075/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2016, 6:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Desktop containment will match every valid pos, so we should return it only if nothing else matches.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 2acf680 
> 
> Diff: https://git.reviewboard.kde.org/r/127075/diff/
> 
> 
> Testing
> -------
> 
> Added few panels, can now move applets from desktop to every panel (not just the first).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160215/80ab1984/attachment.html>


More information about the Plasma-devel mailing list