Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127072/#review92376
-----------------------------------------------------------



do you know what exactly crashes if discard is not called? I just tried to read the code and also compare it to KWin's code to try to understand why it's needed. From all I can see I don't find a reason why it should crash. The pixmap should still be valid, etc. etc.

Comparing to KWin was tricky as it doesn't composite each window individually, but uses composite of root window. The only relatively related code is the fullscreen unredirection. And there interestingly on unredirection it doesn't call into discardPixmap().

If you don't know that fine and I'll give you shipit. I just wanted to understand ;-)

- Martin Gräßlin


On Feb. 14, 2016, 12:23 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127072/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 12:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357895
>     http://bugs.kde.org/show_bug.cgi?id=357895
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> BUG: 357895
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp 21e655e 
> 
> Diff: https://git.reviewboard.kde.org/r/127072/diff/
> 
> 
> Testing
> -------
> 
> No more crash
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160215/e121361f/attachment.html>