Review Request 127024: Don't filter names if we have mimetypes

Aleix Pol Gonzalez aleixpol at kde.org
Sun Feb 14 23:31:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/
-----------------------------------------------------------

(Updated Feb. 15, 2016, 12:31 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Address issue as pointed by David.


Repository: frameworkintegration


Description
-------

setMimeTypeFilters will call setNameFilter anyway, so we're not missing any entries, on the other hand setMimeFilter will do some nice things using the extra knowledge.


Diffs (updated)
-----

  src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 

Diff: https://git.reviewboard.kde.org/r/127024/diff/


Testing
-------

Tested it while porting okular.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160214/b94fa33a/attachment.html>


More information about the Plasma-devel mailing list