Review Request 126879: [digital-clock] Use iso-codes for country names
Pino Toscano
pino at kde.org
Sun Feb 14 12:09:01 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/
-----------------------------------------------------------
(Updated Feb. 14, 2016, 1:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Localization and Translation (l10n), Plasma and John Layt.
Changes
-------
Submitted with commit fea67bd2ae7549e88952ac6dbcf90392d0ee1458 by Pino Toscano to branch master.
Repository: plasma-workspace
Description
-------
Instead of an hardcoded list of translations of country names, look them up in the iso_3166 domain, provided by iso-codes. The names of countries are changes to their ISO 3166 versions in iso-codes.
Look for iso-codes in cmake, but just as indication of it as runtime dependency.
Diffs
-----
applets/digital-clock/plugin/CMakeLists.txt c22c82a75fe6efecc4a249ebd7e045a6f0385ac5
applets/digital-clock/plugin/timezonesi18n.cpp 6bb465e68bfba4695c79898d630dec5a7075a058
cmake/FindIsoCodes.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126879/diff/
Testing
-------
With Plasma 5.3 (but this code is the same as in master), the configuration of timezoned in the digital clock is translated according to iso-codes.
Thanks,
Pino Toscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160214/9c0856bf/attachment.html>
More information about the Plasma-devel
mailing list