Review Request 127073: AppletQuickItem: Fix finding own attached layout

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92328
-----------------------------------------------------------




src/plasmaquick/appletquickitem.h (line 149)
<https://git.reviewboard.kde.org/r/127073/#comment62977>

    This looks binary incompatible.
    
    Also, add Q_DECL_OVERRIDE



src/plasmaquick/appletquickitem.cpp (line 739)
<https://git.reviewboard.kde.org/r/127073/#comment62978>

    The () are optional, dunno if we have a policy for this, Qt requires them anytime.


- Kai Uwe Broulik


On Feb. 13, 2016, 11:23 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 11:23 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
>     http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> -------
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160213/2b05c5ea/attachment.html>