Review Request 126878: [KRunner] Show single runner name

Kai Uwe Broulik kde at privat.broulik.de
Sat Feb 13 16:34:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/
-----------------------------------------------------------

(Updated Feb. 13, 2016, 5:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Vishesh Handa.


Changes
-------

Submitted with commit 8ef9db163f6bc92b1b74bb3bc142fac72f016beb by Kai Uwe Broulik to branch master.


Repository: plasma-workspace


Description
-------

When in single runner mode (ie. only use a specific runner rather than querying them all) show the name of the current runner.

This restores Plasma 4 behavior and is also somewhat in preparation for the global menu runner where it should be clear that I would currently be searching through the current application's menu.


Diffs
-----

  lookandfeel/contents/runcommand/RunCommand.qml 43f7c55 

Diff: https://git.reviewboard.kde.org/r/126878/diff/


Testing
-------

Name properly shows, layout works both ways without the window getting wider.

I just noticed I could probably hide the category label next to the search result, too, as it's now redundant but I don't know whether a runner can still set a different value for that or if that's always just the runner name?


File Attachments
----------------

Runner name label
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160213/b6a500da/attachment.html>


More information about the Plasma-devel mailing list