Review Request 126878: [KRunner] Show single runner name

Thomas Pfeiffer colomar at autistici.org
Thu Feb 11 16:44:03 UTC 2016



> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote:
> > * A single runner can have multiple categories in its response.
> > * I see nothing from a technical point of view in the patch. I find it slightly ugly, but if the usability guys (and Plasma) are fine with it, ship it!
> 
> Vishesh Handa wrote:
>     *nothing wrong
> 
> Marco Martin wrote:
>     it is kinda ugly i think because is really unbalanced.├╣if the window was larger and the textbox taking at least half the width would probably look better (the fact that it's german, so label longer than usual also doesn't help i guess)
> 
> Kai Uwe Broulik wrote:
>     I explicitly made it so the runner window keeps its size but I can make it grow accordingly. (is even easier code-wise)
> 
> Marco Martin wrote:
>     what about using PlaceholderText for the text filed instead?
>     is not like you always need the runner name to be there
> 
> Kai Uwe Broulik wrote:
>     Good idea. However, doesn't it hide the placeholder as soon as the input has focus, so you'll actually never see it? We could use a label for it though. Might even make sense to have this always ie. "Search for documents, applications, ..." 
>     
>     Usability Team, thoughts?
> 
> Marco Martin wrote:
>     good idea, (maybe even change the behavior of the placeholder altogether?)
>     telegram desktop does that and doesn't appear to be particularly confusing..
> 
> Thomas Pfeiffer wrote:
>     Could you explain what you mean by "use a label for it"? What exactly would the behavior be?
> 
> Kai Uwe Broulik wrote:
>     I meant a custom label so the placeholder text doesn't hide when the field has focus but only if something is typed.
> 
> Marco Martin wrote:
>     basically behavior of the placeholder text going away
>     a) when the text label gets focus
>     b) only when you start typing
>     
>     to me, probably b) makes a bit more sense as i see it used a bit more around (like firefox, telegram)
> 
> Thomas Pfeiffer wrote:
>     Ah okay, thx.
>     In this case this definitely makes sense and I see it as a more elegant solution than a label next to the field.
>     
>     I'll talk to Heiko to see if it makes sense to establish that behavior as the norm in general. I tend towards yes, but I might miss a problem somehwere.
> 
> Marco Martin wrote:
>     I (think, if the qqc styling allows me) can change the behavior in our standard text fields to make the placeholder disappear only upon typing
> 
> Thomas Pfeiffer wrote:
>     We had the idea that only those fields which automatically reseive focus keep their placeholder, whereas the others still remove the placeholder when they are manually focussed. That would mean that developers would have to set the behavior themselves if they know a field automatically gets focus (like in the KRunner case).
> 
> Marco Martin wrote:
>     update: text fields always keep their placeholder until you start typing (that is the behavior we need in this particular case), and we don't have any way to change that from the plasma style
> 
> Thomas Pfeiffer wrote:
>     Oh, right, I just noticed. I's thought it was different. Weird. Ah well, then we're all set anyway :)
> 
> Kai Uwe Broulik wrote:
>     So should I just show the runner name in the placeholder text, or "Search '%1'" / "Search in '%1'" ? Though might not work for every runner name.
>     
>     Also, should there be a placeholdertext "Search..." (or "Search for applications, documents, ...") if nothing is input?

I'd just use "Search...", because we can't list everything KRunner can search for, and just showing some if it might be more confusing then helpful, plus we'd have to check which runners are actually activated


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/#review91645
-----------------------------------------------------------


On Jan. 24, 2016, 9:49 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126878/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 9:49 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When in single runner mode (ie. only use a specific runner rather than querying them all) show the name of the current runner.
> 
> This restores Plasma 4 behavior and is also somewhat in preparation for the global menu runner where it should be clear that I would currently be searching through the current application's menu.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/runcommand/RunCommand.qml 43f7c55 
> 
> Diff: https://git.reviewboard.kde.org/r/126878/diff/
> 
> 
> Testing
> -------
> 
> Name properly shows, layout works both ways without the window getting wider.
> 
> I just noticed I could probably hide the category label next to the search result, too, as it's now redundant but I don't know whether a runner can still set a different value for that or if that's always just the runner name?
> 
> 
> File Attachments
> ----------------
> 
> Runner name label
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160211/286f822a/attachment.html>


More information about the Plasma-devel mailing list