Review Request 126968: Morphingpopups effect, to animate tooltips

[Thomas Lübking]

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote:
> > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86
> > <https://git.reviewboard.kde.org/r/126968/diff/1/?file=442552#file442552line86>
> >
> >     a) let's have AnimationEffect::retarget(id, values...)?! - progress is a private detail of AnimationEffect.
> >     if that returns "bool", you also get around the cleanup issue.
> >     
> >     b) something tells me the duration should probably shorten in this case?
> 
> Marco Martin wrote:
>     will give it a try
> 
> Thomas Lübking wrote:
>     I'll have to revisit the animationeffect class anyway because of the segfault and will implement a function to retarget an animation, so you don't have to spend too much time on it.
> 
> Marco Martin wrote:
>     ok, thanks, I'll wait with this to adapt to the new method when done then
> 
> Marco Martin wrote:
>     any update on AnimationEffect::retarget() ? do you plan to work on that or i can give a try?

I did attach you to https://git.reviewboard.kde.org/r/126981/ ;-)
It's just not been tested and I waited on a comment from you before shipping it *lol*


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review91965
-----------------------------------------------------------


On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 8:51 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
>     https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> this effect, derived from the Maximize one, will take the place of the manual window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error prone, plus it's less jarring when the tooltip sizes changes too, since that gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -----
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160209/31258ed1/attachment.html>