Review Request 127014: Avoid ghost entry in xembed sni proxy.

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127014/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 4:31 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
-------

Submitted with commit 829158f830555c031755c6d4348e684779264342 by Weng Xuetian to branch master.


Bugs: 358719
    https://bugs.kde.org/show_bug.cgi?id=358719


Repository: plasma-workspace


Description
-------

It is possible that window is destroyed before we start to monitor its event.

I notice following errors when 358719 is triggered.
QXcbConnection: XCB error: 3 (BadWindow), sequence: 517, resource id: 113246233, major code: 2 (ChangeWindowAttributes), minor code: 0

Try to check if any error happens before we add our event mask to the window attributes.


Diffs
-----

  xembed-sni-proxy/fdoselectionmanager.h 911df6c 
  xembed-sni-proxy/fdoselectionmanager.cpp f236e9c 

Diff: https://git.reviewboard.kde.org/r/127014/diff/


Testing
-------

358719 is now fixed.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160209/3d877be2/attachment.html>