Review Request 126994: Drop usage of Qt4Support
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Feb 9 02:34:41 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126994/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 3:34 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and René J.V. Bertin.
Changes
-------
Submitted with commit d19b942775f321e64bb01e1ebb0e3f3b5960f4f1 by Aleix Pol to branch master.
Repository: plasma-workspace
Description
-------
As I saw in another RR, the simple fact of using KDELibs4Support in part of a project makes the whole project rely on Qt4Support. That's bad especially in cases where KDELibs4Support is optional, because it will lead to unpredictable results.
Diffs
-----
applets/systemtray/plugin/host.cpp e529aeb
components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp cba87ec
components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h e9d7ef3
components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 8a5ba91
components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h 20fb98e
components/shellprivate/widgetexplorer/widgetexplorer.cpp 7816614
dataengines/dict/dictengine.cpp d851268
dataengines/mpris2/mpris2engine.h ea49515
dataengines/mpris2/multiplexedservice.h 2ab4e6b
dataengines/mpris2/playercontainer.cpp 6c4c875
dataengines/share/shareprovider.cpp ac66fd3
dataengines/statusnotifieritem/statusnotifieritemsource.cpp 097f110
dataengines/weather/ions/wetter.com/ion_wettercom.h 4fbbc69
drkonqi/bugzillaintegration/bugzillalib.cpp 802c5fb
drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp e60fb14
drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp 4f8f4ea
drkonqi/drkonqi.cpp b12c118
libtaskmanager/abstractgroupableitem.cpp 9b86cf1
libtaskmanager/groupmanager.cpp 12b18b0
libtaskmanager/strategies/manualgroupingstrategy.cpp b37ac35
libtaskmanager/strategies/programgroupingstrategy.cpp 6b91bfe
libtaskmanager/taskactions.cpp d1ddf9c
libtaskmanager/taskactions_p.h 535ea5f
libtaskmanager/taskitem.cpp 3b2a418
libtaskmanager/tasksmodel.h 8decf0b
libtaskmanager/tasksmodel.cpp 0abdd93
runners/bookmarks/faviconfromblob.cpp 540db9c
runners/bookmarks/tests/testchromebookmarks.cpp 718e765
shell/currentcontainmentactionsmodel.h 0c27a20
shell/currentcontainmentactionsmodel.cpp d442985
shell/kidenticongenerator.cpp 4e4b25a
shell/panelview.cpp 0eaf553
shell/scripting/backportglobal.h 988b14e
shell/scripting/containment.cpp 5e42bee
shell/scripting/widget.cpp 984e666
wallpapers/image/backgroundlistmodel.h d639b03
wallpapers/image/backgroundlistmodel.cpp b4f81da
wallpapers/image/image.h 295ba22
Diff: https://git.reviewboard.kde.org/r/126994/diff/
Testing
-------
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160209/2920cfdf/attachment.html>
More information about the Plasma-devel
mailing list