Review Request 127012: kio-mtp: port away from deprecated listEntry method

David Edmundson david at davidedmundson.co.uk
Mon Feb 8 15:50:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127012/#review92171
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Feb. 8, 2016, 3:48 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127012/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 3:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> As stated in the method's documentation, usage of the true/false argument is redundant and deprecated, since the slave already calls `finished()`.
> 
> 
> Diffs
> -----
> 
>   mtp/kio_mtp.cpp 79731d177ce8c14bcfce0e3691bc32825ccb9a0a 
> 
> Diff: https://git.reviewboard.kde.org/r/127012/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160208/2b61aeb9/attachment.html>


More information about the Plasma-devel mailing list