Review Request 126962: Animate lock screen initialization

[Aleix Pol Gonzalez]

> On Feb. 8, 2016, 10:29 a.m., Kai Uwe Broulik wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 52
> > <https://git.reviewboard.kde.org/r/126962/diff/2/?file=443681#file443681line52>
> >
> >     onStatusChanged: {
> >     if (status === Loader.Ready)
> >     
> >     ?
> 
> Kai Uwe Broulik wrote:
>     Also, why not just bind? opacity: status === Loader.Ready, done :)
> 
> Aleix Pol Gonzalez wrote:
>     I don't have a problem with it, just tell me why you prefer `status` property to `item`... :)
> 
> Kai Uwe Broulik wrote:
>     I find it cleaner, explicitly asking the status rather than the item
> 
> Marco Martin wrote:
>     From a technical pov, it's important the animation is started as late as possible, when the component is well done instantiating, in order to not skip frames. I have no idea in this context which one of the two is better ;)

Eh..
@Kai: I'm not convinced :). I'll push as is, if it really bothers you, please fix.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126962/#review92153
-----------------------------------------------------------


On Feb. 8, 2016, 4:24 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126962/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 4:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Now it's delayed for a bit, and it looks clunky.
> 
> I did some bug triaging first, so that d_ed doesn't get too grumpy. *Cheers*
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml 2fae632 
>   lookandfeel/contents/lockscreen/LockScreenUi.qml 4b0faf2 
> 
> Diff: https://git.reviewboard.kde.org/r/126962/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160208/67cfe923/attachment-0001.html>