Review Request 126962: Animate lock screen initialization
Kai Uwe Broulik
kde at privat.broulik.de
Mon Feb 8 09:30:20 UTC 2016
> On Feb. 8, 2016, 9:29 vorm., Kai Uwe Broulik wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 52
> > <https://git.reviewboard.kde.org/r/126962/diff/2/?file=443681#file443681line52>
> >
> > onStatusChanged: {
> > if (status === Loader.Ready)
> >
> > ?
Also, why not just bind? opacity: status === Loader.Ready, done :)
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126962/#review92153
-----------------------------------------------------------
On Feb. 8, 2016, 3:24 vorm., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126962/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 3:24 vorm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Now it's delayed for a bit, and it looks clunky.
>
> I did some bug triaging first, so that d_ed doesn't get too grumpy. *Cheers*
>
>
> Diffs
> -----
>
> lookandfeel/contents/lockscreen/LockScreen.qml 2fae632
> lookandfeel/contents/lockscreen/LockScreenUi.qml 4b0faf2
>
> Diff: https://git.reviewboard.kde.org/r/126962/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160208/3b686910/attachment.html>
More information about the Plasma-devel
mailing list