Review Request 126995: Drop usage of Qt4Support

Aleix Pol Gonzalez aleixpol at kde.org
Mon Feb 8 02:05:46 UTC 2016



> On Feb. 7, 2016, 8:17 a.m., Pino Toscano wrote:
> > thumbnail/exrcreator.cpp, line 42
> > <https://git.reviewboard.kde.org/r/126995/diff/1/?file=442821#file442821line42>
> >
> >     `QFile::encodeName()` is needd in this case.

Good catch!


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126995/#review92120
-----------------------------------------------------------


On Feb. 5, 2016, 9:25 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126995/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 9:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> On non-kdelibs4support depending modules.
> 
> 
> Diffs
> -----
> 
>   bookmarks/kio_bookmarks.cpp 7c7dd7a 
>   filenamesearch/kio_filenamesearch.cpp 7501e9c 
>   thumbnail/exrcreator.cpp de7ef4f 
> 
> Diff: https://git.reviewboard.kde.org/r/126995/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160208/114907cf/attachment-0001.html>


More information about the Plasma-devel mailing list