Review Request 126953: Remove Theme Details KCM

Kai Uwe Broulik kde at privat.broulik.de
Sun Feb 7 23:15:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126953/
-----------------------------------------------------------

(Updated Feb. 7, 2016, 11:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Andrew Lake.


Changes
-------

Submitted with commit 35bfaf2978ce4e24c07238b0230dd48b2ac6b566 by Kai Uwe Broulik to branch master.


Repository: plasma-desktop


Description
-------

This removes the theme editor thing in the Desktop Theme KCM.

Most settings in there are either broken or useless nowadays.

The only setting I would miss is different Analog Clock faces which could be done in the Analog Clock directly. What I am missing in general is a custom Panel color/texture or something like that which we don't have in here anyway.


Diffs
-----

  kcms/desktoptheme/CMakeLists.txt 6168686 
  kcms/desktoptheme/DesktopTheme.ui f57cdf8 
  kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 
  kcms/desktoptheme/desktopthemedetails.h 475d893 
  kcms/desktoptheme/desktopthemedetails.cpp ce5c856 
  kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 
  kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 
  kcms/desktoptheme/kcmdesktoptheme.h ac87862 
  kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 
  kcms/desktoptheme/thememodel.cpp bb5bb94 

Diff: https://git.reviewboard.kde.org/r/126953/diff/


Testing
-------

Tab gone.

While at it I also replaced the status label with a proper KMessageWidget


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160207/bb514bdc/attachment-0001.html>


More information about the Plasma-devel mailing list