Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Andreas Kainz]

> On Feb. 2, 2016, 12:37 a.m., Andrew Lake wrote:
> > Nice improvement. If the week numbers look ok then +1 from me.
> 
> Kai Uwe Broulik wrote:
>     I need some inspiration for how to align the week names, though.
>     
>     The more I look at it now the better I like it. I tried vertically centering them but that looks awful. On the other hand I really don't want to touch the grid painting code (eg. reduce the height of that row)

in the existing plasmoid the week names where to small and when you make the plasmoid really big they doesn't scale well. can you use the same size than for the days and vertical align bottom horizontal align center as it is now. And I miss the screenshot with the week name. In addition does the plasmoid work in an sidebar panel (minimum size).


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91907
-----------------------------------------------------------


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
>     http://bugs.kde.org/show_bug.cgi?id=336124
>     http://bugs.kde.org/show_bug.cgi?id=348362
>     http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This removes the custom label-based triangles and replaces them with proper ToolButtons using proper icons. It also adds a "Today" button to return to the current day. Also, tooltips that reflect the actual action ("Previous Month", "Previous Year", "Previous Decade", depending on the zoom level) were added.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160204/fd0d829e/attachment.html>