Review Request 126952: Set layout in kickoff config properly

David Edmundson david at davidedmundson.co.uk
Thu Feb 4 22:36:09 UTC 2016



> On Feb. 2, 2016, 9:29 a.m., Marco Martin wrote:
> > applets/kickoff/package/contents/ui/ConfigGeneral.qml, line 39
> > <https://git.reviewboard.kde.org/r/126952/diff/2/?file=442515#file442515line39>
> >
> >     maybe look and feel package?

right, but all I'm changing here is the indentation so I don't want to adjust that it in this patch.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126952/#review91931
-----------------------------------------------------------


On Feb. 1, 2016, 11:20 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126952/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 11:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Existing layout wasn't bound to anything so no labels would clip if they
> got too wide. We were just lucky all text was short.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml aa345a508cc9da5c148b6237d4446627cd6656a1 
> 
> Diff: https://git.reviewboard.kde.org/r/126952/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160204/283d4724/attachment.html>


More information about the Plasma-devel mailing list