Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

[Martin Gräßlin]

> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote:
> > FYI, This may not entirely work as https://bugs.kde.org/show_bug.cgi?id=358869 shows
> 
> David Edmundson wrote:
>     ack, there's a new message that we're not catching.
>     
>     I don't know what the string is though.
> 
> Martin Klapetek wrote:
>     I was thinking we could maybe check the GL version ourselves at the very start?
>     There's a glXQueryVersion function for it. That would effectively catch all these
>     crashes on no GL..?

you can find the new string in http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/items/qquickwindow.cpp?h=v5.5.1#n2566

But there seems to be a better way according to http://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/scenegraph/qsgrenderloop.cpp?h=v5.5.1#n233

Apparently we can get a signal on the QQuickWindow.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124576/#review92059
-----------------------------------------------------------


On Aug. 1, 2015, 2:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124576/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2015, 2:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show a dialog if Plasma failed to create an OpenGL Context.
> 
> remove that "shutup" option we had, it was a workaround for an issue with Qt5.1 spewing warnings constantly.
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp cec4a69c6276de61d776f323fb4b5cebe73f4c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/124576/diff/
> 
> 
> Testing
> -------
> 
> Normal plasma is the same as before.
> I don't know how to break my openGL, but placing a random qFatal() with the same error message got my dialog perfectly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160204/71a3a0bc/attachment-0001.html>