Review Request 126968: Morphingpopups effect, to animate tooltips
Anthony Fieroni
bvbfan at abv.bg
Thu Feb 4 12:37:38 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92054
-----------------------------------------------------------
effects/morphingpopups/package/contents/code/morphingpopups.js (line 22)
<https://git.reviewboard.kde.org/r/126968/#comment62799>
Make duration depend on animation speed config, pls.
Below also.
- Anthony Fieroni
On Фев. 2, 2016, 10:51 след обяд, Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> -----------------------------------------------------------
>
> (Updated Фев. 2, 2016, 10:51 след обяд)
>
>
> Review request for kwin and Plasma.
>
>
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
>
>
> Repository: kwin
>
>
> Description
> -------
>
> this effect, derived from the Maximize one, will take the place of the manual window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error prone, plus it's less jarring when the tooltip sizes changes too, since that gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
>
> replaces https://git.reviewboard.kde.org/r/126870
>
>
> Diffs
> -----
>
> effects/CMakeLists.txt dec50a9
> effects/backgroundcontrast/contrast.cpp 168deb0
> effects/blur/blur.cpp a360f03
> effects/morphingpopups/CMakeLists.txt PRE-CREATION
> effects/morphingpopups/package/CMakeLists.txt PRE-CREATION
> effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION
> effects/morphingpopups/package/metadata.desktop PRE-CREATION
> libkwineffects/kwinanimationeffect.h f59eedc
> libkwineffects/kwinanimationeffect.cpp 579535b
> scripting/scriptedeffect.h 2a77a2f
> scripting/scriptedeffect.cpp 7ab065b
>
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160204/6425929f/attachment.html>
More information about the Plasma-devel
mailing list