Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126961/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 5:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 5a1a411b41f950e97d80ff7c898052fb6d02fb1a by David Edmundson to branch master.


Bugs: 351777
    https://bugs.kde.org/show_bug.cgi?id=351777


Repository: plasma-workspace


Description
-------

We were mixing KScreen and QScreen API badly.

Corona.cpp checks we are requesting a containment for a valid screen
if (screen >= 0 && screen < numScreens()) {

This fails as numScreens() is Qt API based, whereas the signal we're
adding the output for is ShellCorona::addOutput so we have an effective race condition.

BUG: 351777


Diffs
-----

  shell/shellcorona.cpp 762e503bf59fe648fb0f5b76a36229aa43c563e5 

Diff: https://git.reviewboard.kde.org/r/126961/diff/


Testing
-------

Started Plasma on dual screen.

Ideally we need to do more testing before backporting, as that entire codebase is a disgrace.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160203/2f2a377a/attachment.html>