Review Request 126970: gtk.css points to nonexistent files (bad filename)

[Efrem Mc]

I made changes without reviewing the changelog to see if the changes were
noted.  There were only two changes to use:
scrollbar-slider-horizontal-... from scrollbar-slider-overlay-horizontal....

As scrollbar-slider-horizontal.png and scrollbar-slider-horizontal at 2.png
already existed inside the css file.


On Tue, Feb 2, 2016 at 1:31 PM, Gustavo Alvarez <sl1pkn07 at gmail.com> wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126970/
>
> On Febrero 2nd, 2016, 8:14 p.m. UTC, *Efrem McCrimon* wrote:
>
> I tested this my making changes in /usr/share/themes/Breeze-Dark/gtk-3.0/gtk.css and in /usr/share/themes/Breeze/gtk-3.0/gtk.css
>
> There were two edits because of the name change.  Furthermore, there were already three other lines with the new names already in place.
>
> The changes were made only in the css for gtk-3.0.
>
> Regards,
> Efrem McCrimon
>
> Reference:
> Linux: OpenMandriva LX3 2015.0
>
> 4.1.15-nrjQL-desktop-1omv #1 SMP PREEMPT Sun Dec 27 14:47:10 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
>
> Name: Breeze gtk-3.0
> Name: Breeze-Dark gtk-3.0
>
> scrollbar-slider-overlay-horizontal-dark.png
>
> scrollbar-slider-overlay-horizontal.png
>
> Looks like these were renamed to scollbar-slider-horizontal-overlay.png,
>  scollbar-slider-horizontal-overlay-dark.png
>
> https://github.com/horst3180/vertex-theme/tree/master/common/gtk-3.0/3.18/assets
>
> I have based my changes in this theme
>
> scrollbar-slider-overlay-dark.png
> scrollbar-slider-overlay-dark at 2.png
> scrollbar-slider-overlay-horizontal-dark.png
> scrollbar-slider-overlay-horizontal-dark at 2.png
> scrollbar-slider-overlay-horizontal.png
> scrollbar-slider-overlay-horizontal at 2.png
> scrollbar-slider-overlay.png
> scrollbar-slider-overlay at 2.png
>
>
> - Gustavo
>
> On Febrero 2nd, 2016, 4:24 p.m. UTC, Gustavo Alvarez wrote:
> Review request for Plasma and Andreas Sturmlechner.
> By Gustavo Alvarez.
>
> *Updated Feb. 2, 2016, 4:24 p.m.*
> *Bugs: * 356395 <https://bugs.kde.org/show_bug.cgi?id=356395>
> *Repository: * breeze-gtk
> Description
>
> breeze-dark and breeze GTK3 theme have a assets files with wrong names, this patch rename these files according with the gtk.css file
>
> renamig these files fix this message:
>
> Gtk-WARNING **: Error loading image 'file:///usr/share/themes/Breeze-Dark/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png': Error opening file: No such file or directory
>
> Diffs
>
>    - Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png
>    (6d21caf)
>    -
>    Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark at 2.png
>    (09ed07f)
>    - Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png
>    (b260f91)
>    -
>    Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay at 2.png
>    (5884f60)
>    - Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png
>    (PRE-CREATION)
>    -
>    Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark at 2.png
>    (PRE-CREATION)
>    - Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png
>    (PRE-CREATION)
>    -
>    Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal at 2.png
>    (PRE-CREATION)
>    - Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png
>    (6d21caf)
>    -
>    Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark at 2.png
>    (09ed07f)
>    - Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png
>    (b260f91)
>    - Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay at 2.png
>    (5884f60)
>    - Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png
>    (PRE-CREATION)
>    -
>    Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark at 2.png
>    (PRE-CREATION)
>    - Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png
>    (PRE-CREATION)
>    - Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal at 2.png
>    (PRE-CREATION)
>
> View Diff <https://git.reviewboard.kde.org/r/126970/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160202/f53a1585/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk.css
Type: text/css
Size: 203322 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160202/f53a1585/attachment-0002.css>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk.css
Type: text/css
Size: 194727 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160202/f53a1585/attachment-0003.css>