Review Request 126968: Morphingpopups effect, to animate tooltips

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92010
-----------------------------------------------------------



I like it, bunch of nitpicky nitpicks below


effects/morphingpopups/package/contents/code/morphingpopups.js (line 48)
<https://git.reviewboard.kde.org/r/126968/#comment62768>

    Superfluous space



effects/morphingpopups/package/contents/code/morphingpopups.js (lines 95 - 97)
<https://git.reviewboard.kde.org/r/126968/#comment62770>

    Spaces: (foo) / 2
    
    Also below



effects/morphingpopups/package/contents/code/morphingpopups.js (line 107)
<https://git.reviewboard.kde.org/r/126968/#comment62771>

    Whitespace



effects/morphingpopups/package/metadata.desktop (line 19)
<https://git.reviewboard.kde.org/r/126968/#comment62766>

    Remove



effects/morphingpopups/package/metadata.desktop (line 22)
<https://git.reviewboard.kde.org/r/126968/#comment62765>

    This files doesn't exist :)



libkwineffects/kwinanimationeffect.cpp (line 250)
<https://git.reviewboard.kde.org/r/126968/#comment62773>

    const?



libkwineffects/kwinanimationeffect.cpp (line 253)
<https://git.reviewboard.kde.org/r/126968/#comment62772>

    auto



scripting/scriptedeffect.cpp (line 355)
<https://git.reviewboard.kde.org/r/126968/#comment62777>

    QVector



scripting/scriptedeffect.cpp (lines 359 - 360)
<https://git.reviewboard.kde.org/r/126968/#comment62775>

    Braces pls
    
    Also below



scripting/scriptedeffect.cpp (lines 363 - 365)
<https://git.reviewboard.kde.org/r/126968/#comment62774>

    const the list and use range-for


- Kai Uwe Broulik


On Feb. 2, 2016, 8:51 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 8:51 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Bugs: 347863
>     https://bugs.kde.org/show_bug.cgi?id=347863
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> this effect, derived from the Maximize one, will take the place of the manual window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error prone, plus it's less jarring when the tooltip sizes changes too, since that gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
> 
> replaces https://git.reviewboard.kde.org/r/126870
> 
> 
> Diffs
> -----
> 
>   effects/CMakeLists.txt dec50a9 
>   effects/backgroundcontrast/contrast.cpp 168deb0 
>   effects/blur/blur.cpp a360f03 
>   effects/morphingpopups/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/CMakeLists.txt PRE-CREATION 
>   effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION 
>   effects/morphingpopups/package/metadata.desktop PRE-CREATION 
>   libkwineffects/kwinanimationeffect.h f59eedc 
>   libkwineffects/kwinanimationeffect.cpp 579535b 
>   scripting/scriptedeffect.h 2a77a2f 
>   scripting/scriptedeffect.cpp 7ab065b 
> 
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160203/abc2e6a5/attachment-0001.html>