Review Request 126968: Morphingpopups effect, to animate tooltips
Marco Martin
notmart at gmail.com
Wed Feb 3 09:30:27 UTC 2016
> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote:
> > I just wonder, does this change also fix: https://bugs.kde.org/show_bug.cgi?id=241557 ?
> >
> > Also, I have impression that if there's a big difference between the size of two tooltip window, it will look bad.
>
> Thomas Lübking wrote:
> No, completely unrelated issue.
tough it may help, since now blur/contrast do respect the scale factor of windows as well?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126968/#review92000
-----------------------------------------------------------
On Feb. 2, 2016, 8:51 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126968/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 8:51 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Bugs: 347863
> https://bugs.kde.org/show_bug.cgi?id=347863
>
>
> Repository: kwin
>
>
> Description
> -------
>
> this effect, derived from the Maximize one, will take the place of the manual window position animation that Plasma tooltip are using.
> this should cause less problems as animationg positions on X is very error prone, plus it's less jarring when the tooltip sizes changes too, since that gets animated as well (behavior similar to Window7 taskbar tooltips)
> look:
> https://www.youtube.com/watch?v=sxE23ZgkkpU
> slow motion:
> https://www.youtube.com/watch?v=jDByfncO568
>
> replaces https://git.reviewboard.kde.org/r/126870
>
>
> Diffs
> -----
>
> effects/CMakeLists.txt dec50a9
> effects/backgroundcontrast/contrast.cpp 168deb0
> effects/blur/blur.cpp a360f03
> effects/morphingpopups/CMakeLists.txt PRE-CREATION
> effects/morphingpopups/package/CMakeLists.txt PRE-CREATION
> effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION
> effects/morphingpopups/package/metadata.desktop PRE-CREATION
> libkwineffects/kwinanimationeffect.h f59eedc
> libkwineffects/kwinanimationeffect.cpp 579535b
> scripting/scriptedeffect.h 2a77a2f
> scripting/scriptedeffect.cpp 7ab065b
>
> Diff: https://git.reviewboard.kde.org/r/126968/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160203/b44506cc/attachment-0001.html>
More information about the Plasma-devel
mailing list