Review Request 126962: Animate lock screen initialization

[Marco Martin]

> On Feb. 2, 2016, 7:34 p.m., Marco Martin wrote:
> > uuuuh, wait!!one!It's animated already, you are animating it two times :)
> > look at LookScreenUi.qml.
> > it's already fading in. It's not visible because it was units.shortDuration and that is a moment of high CPU load so frames are skipped.
> > if you want the animation to be really visible, just increase the duration there

or remove the animation from there and use this one bu only one should be used.
also, should make sure to start animating only after the component is completed, just on source changed is a bit too early


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126962/#review91987
-----------------------------------------------------------


On Feb. 2, 2016, 3:10 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126962/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 3:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Now it's delayed for a bit, and it looks clunky.
> 
> I did some bug triaging first, so that d_ed doesn't get too grumpy. *Cheers*
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml 2fae632 
> 
> Diff: https://git.reviewboard.kde.org/r/126962/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160202/7a6d8f73/attachment.html>