Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

Marco Martin notmart at gmail.com
Tue Feb 2 10:06:12 UTC 2016



> On Feb. 2, 2016, 9:24 a.m., Marco Martin wrote:
> > what did custom tooltip offered over the standard ones?
> > 
> > folder tooltips are full on folderview and i understand that.
> > what was the particularity of standard tooltips?
> 
> Kai Uwe Broulik wrote:
>     Nothing. They didn't have bigger thumbnails or more information, just icon+text+subtext+broken sizing.

ok, so +1 for me, still advise to wait for Eike tough


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126956/#review91927
-----------------------------------------------------------


On Feb. 1, 2016, 9:23 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126956/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 9:23 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Fixes the tooltips being broken for me (not properly resizing, spacing too large etc)
> 
> I don't see why we would need this.
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderItemDelegate.qml c2d7020 
>   containments/desktop/package/contents/ui/FolderItemToolTipDelegate.qml a8b6f44 
>   containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb 
> 
> Diff: https://git.reviewboard.kde.org/r/126956/diff/
> 
> 
> Testing
> -------
> 
> Works. No more glitchy tooltips.
> 
> (I wish the thumbnails in Folder tooltips were bigger, though)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160202/824565e4/attachment.html>


More information about the Plasma-devel mailing list