Review Request 126950: Fix kicker userExtraRunners

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126950/#review91896
-----------------------------------------------------------




applets/kicker/package/contents/ui/main.qml (line 149)
<https://git.reviewboard.kde.org/r/126950/#comment62718>

    Array.prototype.push.apply(runners, plasmoid.configuration.extraRunners)
    
    is faster, sigh, JavaScript...
    
    https://jsperf.com/array-prototype-push-apply-vs-concat/20


- Kai Uwe Broulik


On Feb. 1, 2016, 7:52 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126950/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 7:52 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> array.concat(array2) creates a new array, it does not edit the initial
> object as one would expect
> 
> 
> Diffs
> -----
> 
>   applets/kicker/package/contents/ui/main.qml 689a598b06580c11995d9730eb6460d4dc831336 
> 
> Diff: https://git.reviewboard.kde.org/r/126950/diff/
> 
> 
> Testing
> -------
> 
> New results appear, though to me the UI looks a bit broken. I think this was masking another bug?
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/03643d32/attachment.html>