Review Request 126952: Set layout in kickoff config properly

Mon Feb 1 21:21:23 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126952/#review91895
-----------------------------------------------------------


applets/kickoff/package/contents/ui/ConfigGeneral.qml (line 28)
<https://git.reviewboard.kde.org/r/126952/#comment62717>

    Why not make this the ColumnLayout? Should give you sensible minimum sizing of the dialog and stuff for free?


- Kai Uwe Broulik


On Feb. 1, 2016, 7:52 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126952/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 7:52 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Existing layout wasn't bound to anything so no labels would clip if they
> got too wide. We were just lucky all text was short.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml aa345a508cc9da5c148b6237d4446627cd6656a1 
> 
> Diff: https://git.reviewboard.kde.org/r/126952/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/ade649fe/attachment.html>