Review Request 126930: sddm theme: Add keyboard layout button

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/#review91811
-----------------------------------------------------------



>Btw, there is a comment saying that password input must be first child to get focus (automatically when login screen is shown?),

That comment is valid and it does do something.
It's about tab order when we enter the buttons area.

I wanted password to always come after the user input bar; so pressing shift+tab changes user, tab is back on password. As they are the most important elements.

- David Edmundson


On Feb. 1, 2016, 10:17 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126930/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 10:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show keyboard layout button in sddm theme, same as in lock screen.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/loginmanager/Main.qml 1bbefec 
>   lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126930/diff/
> 
> 
> Testing
> -------
> 
> Looks & works exactly the same as in lock screen.
> 
> Btw, there is a comment saying that password input must be first child to get focus (automatically when login screen is shown?), but it is not true. It works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual sddm session) even with password input being second child. So, remove the comment?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/38ae058c/attachment.html>