Review Request 126938: [Widget Explorer] Show desktop on dragging widget

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126938/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 3:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Martin Gräßlin.


Changes
-------

Submitted with commit 1aab04cec1c479d68171216b877d1b91a7af5adc by Kai Uwe Broulik to branch master.


Bugs: 327530
    https://bugs.kde.org/show_bug.cgi?id=327530


Repository: plasma-desktop


Description
-------

When starting to drag a widget, show desktop mode is enabled causing all windows but the widget explorer to disappear.

Windows are only restored when widget explorer closes, not as soon as you drop it, so you can see where you dropped the widget and configure it right away also.


Diffs
-----

  desktoppackage/contents/explorer/AppletDelegate.qml c315b4c 
  desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 

Diff: https://git.reviewboard.kde.org/r/126938/diff/


Testing
-------

Opened widget explorer from my panel, started dragging a widget, windows disappeared, dropped on desktop, closed widget explorer, windows re-appeared.

There's a glitch when you drop a widget and then open its config dialog, widget explorer does not automatically hide thus keeping show desktop enabled and the config dialog disappears immediately after it was shown.

I guess this is because hide on window deactivate in Dialog checks for whether I tapped a containment, which I did, and then keeps the dialog open.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160201/1e5f3e14/attachment-0001.html>